Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run upgrade assistant on all samples. #1013

Merged
merged 1 commit into from
May 7, 2024

Conversation

DanAlbert
Copy link
Member

Not quite all. I skipped the other-builds directory because 'tis a silly place that needs to just be merged with the core samples properly as a build variant rather than being a distinct project.

@DanAlbert DanAlbert requested review from rprichard and jfgoog May 6, 2024 22:56
@DanAlbert DanAlbert enabled auto-merge (rebase) May 6, 2024 22:56
Not quite all. I skipped the other-builds directory because 'tis a silly
place that needs to just be merged with the core samples properly as a
build variant rather than being a distinct project.
Copy link
Contributor

@jfgoog jfgoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not scrutinize every diff; I assume these are all automated changes. Anything you did that was manual should be in a separate change.

@DanAlbert DanAlbert merged commit 8dd3418 into android:main May 7, 2024
2 checks passed
@DanAlbert
Copy link
Member Author

I did not scrutinize every diff; I assume these are all automated changes. Anything you did that was manual should be in a separate change.

It's all automatic, or minor fixups that the automated change required (adding the namespace property in a project or two that was missing it). That can't be done in a separate change because the build breaks without it.

@DanAlbert DanAlbert deleted the upgrade-assistant branch May 7, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants