ConnectionProvider: Create a Connection object which includes the iio_context and the CommandQueue. #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlexandraTrifan
commented
Oct 19, 2023
AlexandraTrifan
commented
- Change the behavior of the CommandQueue.
- Introduce the Connection object which handles the iio_context and CommandQueue creation and destruction.
- Handle the reference count inside the Connection object.
- Emit a signal when the Connection reference count is 0 and the object is about to be destroyed. Every client of the ConnectionProvider should make sure that this signal is handled and no further operations regarding iio_context or CommandQueue are performed.
- Add a closeAll() method to force the destruction of the Connection and signal all the other clients to deinitialize.
AlexandraTrifan
force-pushed
the
connection-obj-provider
branch
from
e433132
to
045f606
Compare
AlexandraTrifan
force-pushed
the
connection-obj-provider
branch
3 times, most recently
from
0d6c3ca
to
f6c22b1
Compare
Signed-off-by: AlexandraTrifan <[email protected]>
The open() and close() calls are done through a singleton ConnectionProvider while the reference count is handled inside the Connection object. This should replace the existing ContextProvider. Signed-off-by: AlexandraTrifan <[email protected]>
Signed-off-by: AlexandraTrifan <[email protected]>
AlexandraTrifan
force-pushed
the
connection-obj-provider
branch
from
f6c22b1
to
4fa1ed6
Compare
adisuciu
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.