Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable serial backend on OSX #1007

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Enable serial backend on OSX #1007

merged 3 commits into from
Jul 14, 2023

Conversation

pcercuei
Copy link
Contributor

Compile Libiio against libserialport to activate the serial backend on OSX.

@pcercuei pcercuei requested a review from ccraluca July 13, 2023 14:55
@pcercuei pcercuei force-pushed the pcercuei/master-osx-libserialport branch 2 times, most recently from bcd103f to 4feaf9f Compare July 13, 2023 15:34
@pcercuei pcercuei marked this pull request as ready for review July 13, 2023 15:43
@pcercuei pcercuei force-pushed the pcercuei/master-osx-libserialport branch 3 times, most recently from ef5fe46 to 72c1b7b Compare July 14, 2023 09:49
@pcercuei
python: Rework bindings install
b962819 
Compute the full path to the library, otherwise install of the bindings
may fail as it cannot find the installed shared library on OSX.

Signed-off-by: Paul Cercueil <[email protected]>
@pcercuei
CI: Don't force CMAKE_SYSTEM_NAME for OSX
b17593a 
It was done to address an issue with the Python bindings, which was
solved differently.

Signed-off-by: Paul Cercueil <[email protected]>
@pcercuei
CI: Enable serial backend on OSX
4136545 
Compile Libiio against libserialport to activate the serial backend on
OSX.

Signed-off-by: Paul Cercueil <[email protected]>
@pcercuei pcercuei force-pushed the pcercuei/master-osx-libserialport branch from 72c1b7b to 4136545 Compare July 14, 2023 10:40
@pcercuei pcercuei requested a review from tfcollins July 14, 2023 10:59
rgetz
rgetz approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@rgetz rgetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I think this will help folks.

rgetz
rgetz approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@rgetz rgetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@pcercuei pcercuei merged commit f5ded6a into master Jul 14, 2023
23 checks passed
@pcercuei pcercuei deleted the pcercuei/master-osx-libserialport branch July 14, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgetz rgetz rgetz approved these changes

@ccraluca ccraluca ccraluca approved these changes

@tfcollins tfcollins Awaiting requested review from tfcollins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcercuei @rgetz @ccraluca