Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnssd: Append interface number to IPv6 link-local addresses #1006

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

pcercuei
Copy link
Contributor

Just like we do with Avahi, append the interface identifier to the IPv6 link-local addresses.

@pcercuei pcercuei force-pushed the pcercuei/master-fix-dns-win branch from f32482f to 5fef94e Compare July 11, 2023 08:29
@pcercuei pcercuei marked this pull request as ready for review July 12, 2023 07:34
Just like we do with Avahi, append the interface identifier to the IPv6
link-local addresses.

Signed-off-by: Paul Cercueil <[email protected]>
@pcercuei pcercuei force-pushed the pcercuei/master-fix-dns-win branch from 5fef94e to 24024a5 Compare July 12, 2023 07:53
@pcercuei
Copy link
Contributor Author

Restored IPv6 scanning support on OSX as well.

Copy link
Contributor

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor stuff from my side...

dns_sd_bonjour.c Outdated Show resolved Hide resolved
dns_sd_bonjour.c Outdated Show resolved Hide resolved
The code would discard discovered IPv6 addresses in favour of IPv4 ones.
Also, the IPv6 addresses discovered did not have the interface
specifier, which caused context creation to fail.

Signed-off-by: Paul Cercueil <[email protected]>
@pcercuei pcercuei force-pushed the pcercuei/master-fix-dns-win branch from 4284029 to 519f3a1 Compare July 13, 2023 14:25
@pcercuei pcercuei merged commit c74e32e into master Jul 13, 2023
23 checks passed
@pcercuei pcercuei deleted the pcercuei/master-fix-dns-win branch July 13, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants