Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various refactoring #1042

Merged
merged 16 commits into from
Apr 23, 2024
Merged

Various refactoring #1042

merged 16 commits into from
Apr 23, 2024

Conversation

rieder
Copy link
Member

@rieder rieder commented Apr 3, 2024

No description provided.

@rieder rieder marked this pull request as ready for review April 3, 2024 11:36
@rieder rieder requested a review from a team as a code owner April 3, 2024 11:36
@rieder
Copy link
Member Author

rieder commented Apr 3, 2024

Mostly refactoring files with the black tool, but also includes some manual fixes (e.g. spelling corrections), removing obsolete syntax, and extending functionality by passing **kwargs

LourensVeen
LourensVeen previously approved these changes Apr 23, 2024
Copy link
Collaborator

@LourensVeen LourensVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few things to look at and maybe fix but I'm happy to merge as-is too.

src/amuse/couple/bridge.py Outdated Show resolved Hide resolved
src/amuse/couple/bridge.py Outdated Show resolved Hide resolved
src/amuse/ic/plummer.py Outdated Show resolved Hide resolved
src/amuse/ic/kingmodel.py Show resolved Hide resolved
@rieder rieder merged commit 3e267c6 into amusecode:main Apr 23, 2024
5 of 8 checks passed
@rieder rieder deleted the refactoring_feb2024 branch April 23, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants