W-15702938 Added tests for AVRO and AVRO support in async2.6 #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into W-15702938-TestsAvroDiagnostics
llibarona
reviewed
Oct 7, 2024
|
|
||
| import scala.concurrent.ExecutionContext | ||
|
|
||
| class Async26Test extends BasicCleanDiagnosticTest { |
There was a problem hiding this comment.
Maybe a more specific name like "Async26CleanDiagnosticTest`
| import org.mulesoft.lsp.feature.diagnostic.DiagnosticSeverity | ||
|
|
||
|
|
||
| class AvroSupportTest extends BasicCleanDiagnosticTest { |
There was a problem hiding this comment.
maybe change name to AvroCleanDiagnosticTest?
| server.shutdown() | ||
| assert(d.size == 2) | ||
| assert(d.head.diagnostics.length == 1) | ||
| val errorMessage = d.head.diagnostics.head.message.toLowerCase() |
There was a problem hiding this comment.
maybe instead of diagnostics.head use a find or collect, so we do not rely on the order of the files sent (check by uri)
| } | ||
|
|
||
|
|
||
| test("avro containing inline avro") { |
There was a problem hiding this comment.
not sure what inline avro inside an avro means, maybe just leave this as "valid complex avro" or something?
| } | ||
| } | ||
|
|
||
| test("Avro with no errors") { |
There was a problem hiding this comment.
maybe "valid avro with unions"?
llibarona
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.