SD/feat#64 Added book search #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sarajaned
commented
Aug 19, 2023
sarajaned
commented
- by title and author initially
- used JPA Specification
JaafarF
approved these changes
Aug 20, 2023
There was a problem hiding this comment.
Globally good job, I will accept the PR, well done.
I have couple of points that can be dealt with in a separate Fix Branch:
-
Search feature: the query term is case sensitive, if I have a book of author 'Smith', and I make a search with the query 'smith', no results are returned. Also the tests don't detect this bug.
-
In BookService: this String literal is duplicated "Book with id [%s] not found." , we can put it in a constant.
-
In BookController: ResponseEntity<?> Generic wildcard (question mark) types should not be used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.