Review Modifications

amigoscode · Aug 31, 2023 · 7fa5103 · 7fa5103
1 parent 55f80b9
commit 7fa5103
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 40 deletions.
diff --git a/...ore/src/main/java/com/amigoscode/cohort2d/onlinebookstore/OnlineBookStoreApplication.java b/...ore/src/main/java/com/amigoscode/cohort2d/onlinebookstore/OnlineBookStoreApplication.java
@@ -1,19 +1,7 @@
 package com.amigoscode.cohort2d.onlinebookstore;
 
-import com.amigoscode.cohort2d.onlinebookstore.address.AddressDao;
-import com.amigoscode.cohort2d.onlinebookstore.book.Book;
-import com.amigoscode.cohort2d.onlinebookstore.book.BookDAO;
-import com.amigoscode.cohort2d.onlinebookstore.order.Order;
-import com.amigoscode.cohort2d.onlinebookstore.order.OrderDAO;
-import com.amigoscode.cohort2d.onlinebookstore.order.OrderItem;
-import com.amigoscode.cohort2d.onlinebookstore.user.UserDao;
-import org.springframework.boot.CommandLineRunner;
 import org.springframework.boot.SpringApplication;
 import org.springframework.boot.autoconfigure.SpringBootApplication;
-import org.springframework.context.annotation.Bean;
-
-import java.math.BigDecimal;
-import java.time.LocalDateTime;
 
 @SpringBootApplication
 public class OnlineBookStoreApplication {

diff --git a/online-book-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/address/Address.java b/online-book-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/address/Address.java
@@ -2,7 +2,9 @@
 
 import jakarta.persistence.*;
 import jakarta.validation.constraints.NotNull;
-import lombok.*;
+import lombok.AllArgsConstructor;
+import lombok.Data;
+import lombok.NoArgsConstructor;
 
 @Entity
 @Table(name = "address")

diff --git a/...-book-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/address/AddressDao.java b/...-book-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/address/AddressDao.java
@@ -10,6 +10,4 @@ public interface AddressDao {
     boolean existAddressById(long id);
 
     Optional<Address> getAddressById(Long addressId);
-
-    Address getAddressReferenceById(Long addressId);
 }
diff --git a/...tore/src/main/java/com/amigoscode/cohort2d/onlinebookstore/address/AddressJpaService.java b/...tore/src/main/java/com/amigoscode/cohort2d/onlinebookstore/address/AddressJpaService.java
@@ -32,9 +32,4 @@ public boolean existAddressById(long id) {
     public Optional<Address> getAddressById(Long addressId) {
         return addressRepository.findById(addressId);
     }
-
-    @Override
-    public Address getAddressReferenceById(Long addressId) {
-        return addressRepository.getReferenceById(addressId);
-    }
 }
diff --git a/online-book-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/book/Book.java b/online-book-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/book/Book.java
@@ -8,7 +8,10 @@
 import jakarta.validation.constraints.NotEmpty;
 import jakarta.validation.constraints.NotNull;
 import jakarta.validation.constraints.Size;
-import lombok.*;
+import lombok.AllArgsConstructor;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
 
 import java.math.BigDecimal;
 import java.time.LocalDate;

diff --git a/online-book-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/book/BookDAO.java b/online-book-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/book/BookDAO.java
@@ -3,7 +3,6 @@
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 
-import java.util.List;
 import java.util.Optional;
 
 public interface BookDAO {

diff --git a/...store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/category/CategoryService.java b/...store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/category/CategoryService.java
@@ -3,11 +3,9 @@
 import com.amigoscode.cohort2d.onlinebookstore.exceptions.DuplicateResourceException;
 import com.amigoscode.cohort2d.onlinebookstore.exceptions.RequestValidationException;
 import com.amigoscode.cohort2d.onlinebookstore.exceptions.ResourceNotFoundException;
-import com.github.javafaker.Cat;
 import org.springframework.stereotype.Service;
 
 import java.util.List;
-import java.util.Optional;
 
 @Service
 public class CategoryService {

diff --git a/...-book-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/order/OrderService.java b/...-book-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/order/OrderService.java
@@ -31,11 +31,6 @@ public Order addOrder(Order order) {
         return orderDAO.addOrder(order);
     }
 
-    /*public List<OrderDTO> getOrders() {
-        List<Order> all = orderDAO.getOrdersByUserId(userId);
-        return OrderDTOMapper.INSTANCE.modelToDTO(all);
-    }*/
-
     public List<OrderDTO> getOrdersByUserId(Long userId) {
         List<Order> all = orderDAO.getOrdersByUserId(userId);
         return OrderDTOMapper.INSTANCE.modelToDTO(all);

diff --git a/online-book-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/user/User.java b/online-book-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/user/User.java
@@ -5,7 +5,9 @@
 import jakarta.persistence.*;
 import jakarta.validation.constraints.Email;
 import jakarta.validation.constraints.NotBlank;
-import lombok.*;
+import lombok.AllArgsConstructor;
+import lombok.Data;
+import lombok.NoArgsConstructor;
 
 import java.util.ArrayList;
 import java.util.HashSet;
@@ -77,16 +79,6 @@ public User(@NotBlank String firstName, @NotBlank String lastName, String email,
         this.orders = orders;
     }
 
-    public void add(Order order) {
-        if (order != null) {
-            if (orders == null) {
-                orders = new HashSet<>();
-            }
-            orders.add(order);
-            order.setUser(this);
-        }
-    }
-
     public void addAddress(Address address) {
         if (addresses == null) {
             addresses = new ArrayList<>();