SD/feat/#59 refactored resource not found in AuthorService

amigoscode · Aug 13, 2023 · 30ad953 · 30ad953
1 parent 139a52f
commit 30ad953
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/...ook-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/author/AuthorService.java b/...ook-store/src/main/java/com/amigoscode/cohort2d/onlinebookstore/author/AuthorService.java
@@ -36,16 +36,15 @@ public AuthorDTO getAuthorById(Long id) {
         return AuthorDTOMapper.INSTANCE.modelToDTO(
                 authorDAO.findById(id)
                 .orElseThrow(
-                        () -> new ResourceNotFoundException("Author with id [%s] not found.".formatted(id))));
+                        () -> getResourceNotFoundException(id)));
     }
 
     public void updateAuthor(Long id, AuthorDTO updateRequest) {
 
         // find book - check exists
         Author existingAuthor = authorDAO.findById(id)
-                .orElseThrow(() -> new ResourceNotFoundException(
-                        "Author with id [%s] not found.".formatted(id)
-                ));
+                .orElseThrow(
+                        () -> getResourceNotFoundException(id));
 
         // check if there are any changes
         if(AuthorDTOMapper.INSTANCE.modelToDTO(existingAuthor).equals(updateRequest)){
@@ -69,11 +68,19 @@ public void updateAuthor(Long id, AuthorDTO updateRequest) {
     public void deleteAuthorById(Long id) {
 
         // if author does not exist throw
-        if(!authorDAO.existsAuthorById(id)){
-            throw new ResourceNotFoundException("Author with id [%s] not found.".formatted(id));
-        }
+        checkIfAuthorExistsOrThrow(id);
 
         //delete
         authorDAO.deleteAuthorById(id);
     }
+
+    private void checkIfAuthorExistsOrThrow(Long id) {
+        if(!authorDAO.existsAuthorById(id)) {
+            throw getResourceNotFoundException(id);
+        }
+    }
+
+    private static ResourceNotFoundException getResourceNotFoundException(Long id) {
+        return new ResourceNotFoundException("Author with id [%s] not found.".formatted(id));
+    }
 }