Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the T Pose to HDE #45

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Align the T Pose to HDE #45

merged 5 commits into from
Sep 17, 2024

Conversation

davidegorbani
Copy link
Collaborator

This PR adds two methods to align the T Pose computation to the one implemented in HDE; those two methods allow to reset the offset on the yaw of the IMUs and compute the IMU_R_link rotation matrix.

@Gianlucamilani
Copy link
Contributor

do you think we should dismiss the old (wrong) calibration algorithm? @davidegorbani

@davidegorbani
Copy link
Collaborator Author

do you think we should dismiss the old (wrong) calibration algorithm? @davidegorbani

Yes, we can remove it since it could generate confusion otherwise.

Copy link
Contributor

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

@davidegorbani
Copy link
Collaborator Author

Thank you! Merging!

@davidegorbani davidegorbani merged commit b150498 into main Sep 17, 2024
6 checks passed
@davidegorbani davidegorbani deleted the fixTPose branch September 17, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants