Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD build script and patches #938

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tpoindex
Copy link

This patch adds support for building Vosk-API under FreeBSD. A couple of notes: I didn't see a good place to stick the build script, so I create a 'misc' directory. There is a small patch to the upstream Kaldi to add FreeBSD support, currently it's inline in the build script, I'll also submit a PR to Kaldi for this. There a two small patches to Vosk files, one just adds FreeBSD support to the Python package, the other makes simple changes to c/Makefile to use generic $(CC) and $(CXX) makefile definitions. All C/C++ compilation is done with clang in FreeBSD. Last, I've only tested building for C and Python.

@nshmyrev
Copy link
Collaborator

Thanks! Looks great.

makefile change could go to kaldi repo indeed, maybe even to upstream kaldi, should we just wait for it then?

@tpoindex
Copy link
Author

I've summited an upstream PR to Kaldi master, kaldi-asr/kaldi#4733.

@nshmyrev
Copy link
Collaborator

Thanks! Few days then.

@tpoindex
Copy link
Author

Kaldi maintainers merged my FreeBSD patches into master: kaldi-asr/kaldi#4733

@nshmyrev
Copy link
Collaborator

@tpoindex thanks, I've merged into our kaldi as well, now build should be easier.

@tpoindex
Copy link
Author

Great, I'll update this PR to exclude the inline patches to Kaldi, might not be for a few days.

@tpoindex
Copy link
Author

Updated the commit to remove the Kaldi in-stream patches, which are now included in upstream kaldi-asr/kaldi master as well as the alphacep/kaldi vosk branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants