spring boot 3.3.2 #430
Open
spring boot 3.3.2 #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozjan
force-pushed
the
spring-boot-3.3.2
branch
6 times, most recently
from
cca57be
to
fc048a2
Compare
kozjan
force-pushed
the
spring-boot-3.3.2
branch
from
b2e395b
to
c85367c
Compare
kozjan
force-pushed
the
spring-boot-3.3.2
branch
from
fc25097
to
50a28ba
Compare
kozjan
force-pushed
the
spring-boot-3.3.2
branch
from
ce9aff7
to
6ce78d6
Compare
Ferdudas97
approved these changes
Sep 20, 2024
| (0 until innerSources).forEach { | ||
| meterRegistry.gauge("${bufferMetric(name)}_$it", scannable, innerBufferExtractor(it)) | ||
| for (i in 0 until innerSources) { | ||
| meterRegistry.gauge("${bufferMetric(name)}_$i", scannable, innerBufferExtractor(i)) |
There was a problem hiding this comment.
detekt was failing with information that there is an overhead with forEach and for should be used instead
| throw IllegalArgumentException( | ||
| "Only one of: exactMatch, regexMatch can be defined." | ||
| ) | ||
| require(headerMatcher.exactMatch.isEmpty() || headerMatcher.regexMatch.isEmpty()) { |
There was a problem hiding this comment.
why you changed this checks to require?
There was a problem hiding this comment.
detekt failed with information that using require is more idiomatic to kotlin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.