java control plane 1.0.45 #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozjan
force-pushed
the
java-control-plane-1.0.45
branch
from
71dd46a
to
ffc1ac0
Compare
druminski
previously approved these changes
Jun 26, 2024
Ferdudas97
previously approved these changes
Jul 4, 2024
| @@ -39,7 +39,7 @@ class EnvoyContainer( | |||
| private const val ADMIN_PORT = 10000 | |||
|
|
|||
| private const val MIN_SUPPORTED_ENVOY_VERSION = "v1.22.7" | |||
There was a problem hiding this comment.
this version was there since first time introducing it into the repo - I don't know what was the logic behind setting it and I don't see anything in java-control-plane about compatibility
|
Have you tested it on dev environement? |
kozjan
force-pushed
the
java-control-plane-1.0.45
branch
from
ffc1ac0
to
65c4f01
Compare
kozjan
force-pushed
the
java-control-plane-1.0.45
branch
from
65c4f01
to
1fc756d
Compare
KSmigielski
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same update with SimpleCache removed in this PR
SimpleCache is a class that was copied from java-control-plane to add some custom logic - this logic is now in java-control-plane, but for safety I am leaving it in separate PR.