Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the local server with env variable _MINIO_SERVER_LOCAL #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

allanrogerr
Copy link
Owner

@allanrogerr allanrogerr commented Apr 9, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

For systems where the hostname cannot be resolved to local IP, this PR introduces a change allowing the specifying of the local server with env variable _MINIO_SERVER_LOCAL

Motivation and Context

In this sort of system, e.g. a kubernetes cluster within which minio pods is running on nodes on different networks, the internal IP address of the pod is not resolvable from any hostname, accessible externally. Therefore minio is not able to recognize itself within the pool of hosts as no endpoint can be resolved to it's own IP address.

A workaround would be to perform the resolution manually by editing /etc/hosts/ and assigning a consecutive host resolving to the pod ip address. e.g.
<ip of k8s pod> <hostname>.<domain>
e.g.
10.42.0.11 minio-18825-1.lab.min.dev

How to test this PR?

See example here: https://github.com/allanrogerr/public/wiki/minio%E2%80%9018825
1.- Pull and compile http://github.com/allanrogerr/minio.git on several k8s pods
2.- Run minio on all pods e.g.

CI=on \
_MINIO_SERVER_LOCAL=minio-18825-1.lab.min.dev:9000 \
~/github/minio/minio server https://minio-18825-{0...1}.lab.min.dev:9000/tmp/data{1...2} --address :9000 --console-address :9090 --certs-dir ~/.minio/certs

3.- Observe the minio cluster online

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

…CAL, in systems where the hostname cannot be resolved to local IP
@allanrogerr allanrogerr self-assigned this Apr 9, 2024
@allanrogerr allanrogerr changed the title Allow specifying the local server, with env variable _MINIO_SERVER_LOCAL Allow specifying the local server with env variable _MINIO_SERVER_LOCAL Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant