Wasm cpp bazel #446
Merged
Wasm cpp bazel #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 40.23% 40.23%
=======================================
Files 45 45
Lines 6178 6178
=======================================
Hits 2486 2486
Misses 3519 3519
Partials 173 173 |
CH3CHO
reviewed
Jul 24, 2023
test/e2e/e2e_test.go
Outdated
| @@ -29,6 +30,8 @@ import ( | |||
| ) | |||
|
|
|||
| var isWasmPluginTest = flag.Bool("isWasmPluginTest", false, "") | |||
| var wasmPluginType = flag.String("WasmPluginType", "GO", "") | |||
| var wasmPluginName = flag.String("WasmPluginName", "", "") | |||
johnlanni
requested changes
Jul 25, 2023
test/e2e/e2e_test.go
Outdated
| @@ -29,6 +30,8 @@ import ( | |||
| ) | |||
|
|
|||
| var isWasmPluginTest = flag.Bool("isWasmPluginTest", false, "") | |||
| var wasmPluginType = flag.String("WasmPluginType", "GO", "") | |||
| var wasmPluginName = flag.String("WasmPluginName", "", "") | |||
|
@CH3CHO @johnlanni Just change the e2e_test file param name start with lowercase, pls help me RE again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support make build cpp wasmplugin and do e2e test
Ⅱ. Does this pull request fix one issue?
NO
Ⅲ. Why don't you add test cases (unit test/integration test)?
has e2e test case
Ⅳ. Describe how to verify it
PLUGIN_TYPE=CPP PLUGIN_NAME=key_auth make higress-wasmplugin-test
Ⅴ. Special notes for reviews
NO