feat: add higress base image #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
- Coverage 40.30% 39.98% -0.33%
==========================================
Files 45 45
Lines 6178 6178
==========================================
- Hits 2490 2470 -20
- Misses 3515 3535 +20
Partials 173 173 |
|
@fengshunli Please fix the e2e test. |
fengshunli
force-pushed
the
base
branch
2 times, most recently
from
711d6b3
to
96cc8d0
Compare
@johnlanni approval |
fengshunli
force-pushed
the
base
branch
6 times, most recently
from
c19e301
to
d3a5e8a
Compare
CH3CHO
reviewed
Jul 20, 2023
|
|
||
|
|
||
| docker-build-base: | ||
| docker buildx build --no-cache --platform linux/amd64,linux/arm64 -t ${HUB}/base:${BASE_VERSION} -f docker/Dockerfile.base . --push |
There was a problem hiding this comment.
使用当前的tag来build一个新的base镜像是不是不太合理啊？
fengshunli
force-pushed
the
base
branch
2 times, most recently
from
8a83403
to
0983b5a
Compare
Signed-off-by: fengshunli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews