feat: support rewrite config after parse_rule_config
invoked
#401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Support rewrite config after
parse_rule_config
invoked.The configuration we usually get just describes what we want to do, but at runtime we have many efficient data structures to allow us to complete these tasks more efficiently. For example, there is a coverage relationship between CIDRs, so we only need to keep the one with the largest coverage interval. In addition, for string matching, Radix Trie is far more efficient than list matching, and this needs to be rewritten after the configuration is parsed.
There is no other way for extensions to do the rewriting, because both
global_config
andrule_config
belong torule_matcher
, and they are not public (and cannot be public). So we need a mapping function to do the rewriting.fn(config: &PluginConfig) -> PluginConfig
is not&mut
intentional, I always think that pure functions can simplify the user's mind.There is an example that how to rewrite config
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews