Validate rsa private key and certificate content format #971

DevDengChao · 2020-07-13T03:54:39Z

ChanDaoH · 2020-07-14T02:38:16Z

src/lib/deploy/deploy-support.js

-const { green, red } = require('colors');
-const { processApiParameters } = require('./deploy-support-api');
-const { getCloudApiClient, getSlsClient, getMnsClient } = require('../client');
+const {green, red} = require('colors');


eslint 是如何配置的？

我是在 Windows 上用 WebStorm 开发的, 未修改 .eslintrc 的内容, 对 deploy-support.js 使用 .eslintrc 的格式进行格式化的.
测试后发现有没有空格 eslint 都没有报错.

需要我回滚格式化代码的 commit 么?

ChanDaoH · 2020-07-14T02:40:01Z

src/lib/deploy/deploy-support.js

+      let p = path.resolve(__dirname, privateKey);
+      // private key is provided by local file
+      if (fs.pathExistsSync(p)) {
+        certConfig.PrivateKey = fs.readFileSync(p, 'utf-8');


fs.readFileSync(p, 'utf-8') => await fs.readFile(p, 'utf-8')

ChanDaoH · 2020-07-14T02:40:29Z

src/lib/deploy/deploy-support.js

+      let p = path.resolve(__dirname, certificate);
+      // certificate is provided by local file
+      if (fs.pathExistsSync(p)) {
+        certConfig.Certificate = fs.readFileSync(p, 'utf-8');


fs.readFileSync(p, 'utf-8') => await fs.readFile(p, 'utf-8')

ChanDaoH · 2020-07-14T02:42:21Z

src/lib/deploy/deploy-support.js

+      //endregion
+
+      //region validate RSA private key content
+      let expectedPrefix = '-----BEGIN RSA PRIVATE KEY-----', expectedSuffix = '-----END RSA PRIVATE KEY-----';


写在 const 里面吧

ChanDaoH · 2020-07-14T02:42:31Z

src/lib/deploy/deploy-support.js

+      //endregion
+
+      //region validate certificate content
+      let expectedPrefix = '-----BEGIN CERTIFICATE-----', expectedSuffix = '-----END CERTIFICATE-----';


写在 const 里面吧

ChanDaoH · 2020-07-14T02:43:36Z

test/fs-extra.test.js

+let path = require('path');
+const expect = require('expect.js');
+
+describe('fs-extra module Tests', function () {


这个测试集的作用是？

为了确认 fs-extra 的 pathExists 方法对相对路径的支持方式, 目前确认到的情况是需要使用 path.resolve 先对路径进行解析才行.

为了确认 fs-extra 的 pathExists 方法对 PrivateKey 以及 Certificate 是硬编码的 PEM 内容时的返回结果.

需要添加注释? 还是删掉这个测试集?

This reverts commit 4dda146

DevDengChao · 2021-02-26T01:50:43Z

🤔

DevDengChao · 2021-06-11T06:35:57Z

🤔

CLAassistant · 2022-01-26T02:21:39Z

All committers have signed the CLA.

DevDengChao · 2022-06-28T01:24:33Z

Closed as #1146

DevDengChao added 2 commits July 13, 2020 11:36

chore: reformat deploy-support.js

4dda146

feat: validate rsa private key and certificate content format

09b6e3f

ChanDaoH reviewed Jul 14, 2020

View reviewed changes

DevDengChao added 2 commits July 14, 2020 10:55

refactor: replace fs.readFileSync() with await fs.readFile()

0523b4c

refactor: extract constant value

f11f463

DevDengChao requested a review from ChanDaoH July 14, 2020 03:27

DevDengChao added 2 commits July 14, 2020 11:36

refactor: remove redundant test case

42f70e8

revert: "chore: reformat deploy-support.js"

5caf505

This reverts commit 4dda146

DevDengChao closed this Jun 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate rsa private key and certificate content format #971

Validate rsa private key and certificate content format #971

DevDengChao commented Jul 13, 2020

ChanDaoH Jul 14, 2020

DevDengChao Jul 14, 2020

ChanDaoH Jul 14, 2020 •

edited

Loading

DevDengChao Jul 14, 2020

ChanDaoH Jul 14, 2020

DevDengChao Jul 14, 2020

ChanDaoH Jul 14, 2020

DevDengChao Jul 14, 2020

ChanDaoH Jul 14, 2020

DevDengChao Jul 14, 2020

ChanDaoH Jul 14, 2020

DevDengChao Jul 14, 2020

DevDengChao commented Feb 26, 2021

DevDengChao commented Jun 11, 2021

CLAassistant commented Jan 26, 2022 •

edited

Loading

DevDengChao commented Jun 28, 2022

Validate rsa private key and certificate content format #971

Validate rsa private key and certificate content format #971

Conversation

DevDengChao commented Jul 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChanDaoH Jul 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DevDengChao commented Feb 26, 2021

DevDengChao commented Jun 11, 2021

CLAassistant commented Jan 26, 2022 • edited Loading

DevDengChao commented Jun 28, 2022

ChanDaoH Jul 14, 2020 •

edited

Loading

CLAassistant commented Jan 26, 2022 •

edited

Loading