feat(interactive): Add three builtin procedures #4249
Conversation
|
|
zhanglei1949
changed the title
|
|
||
| namespace gs { | ||
| // A simple app to count the number of vertices of a given label. | ||
| class TVSP : public CypherInternalPbWriteAppBase { |
There was a problem hiding this comment.
Please rename the filename, maybe shortest_path.h?
| #include "flex/engines/hqps_db/app/interactive_app_base.h" | ||
|
|
||
| namespace gs { | ||
| // A simple app to count the number of vertices of a given label. |
There was a problem hiding this comment.
Please check the comments,
- Remove dummy comments
- Remove chinese comments.
|
Thank you for your contribution! Please ensure your code is formatted by running: It's acceptable if the files haven't been modified as they are already formatted. |
|
Please also fix the CodeRefactor issues. |
|
Could you please add tests for the builtin procedures introduced? For example : def test_builtin_procedure(interactive_session,neo4j_session, create_modern_graph): |
|
Is a performance report available? |
|
Please check the preview of the documentation changes at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4249 +/- ##
===========================================
+ Coverage 46.45% 58.78% +12.33%
===========================================
Files 173 12 -161
Lines 16171 592 -15579
===========================================
- Hits 7512 348 -7164
+ Misses 8659 244 -8415 see 185 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
This pull request introduces three built-in stored procedures as per the OSPP requirements. The following stored procedures have been implemented:
Shortest Path Between Three Points: A procedure to compute the shortest path between any given three points in the graph.
K-hop Neighbor Traversal from a Specified Node: A procedure that traverses the graph and retrieves all nodes within k hops from a specified starting node.
PageRank Calculation: A procedure to compute the PageRank values of nodes within the graph.
At present, both k_neighbors and shortest_path_among_three only support types where the id input parameter is of type int64. For example, CALL k_neighbors(1L, "person", 2);
This PR addresses the following issue: #3737
Closes #3737