Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Redix config to support all start_link/1 options #5

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

mdlkxzmcp
Copy link
Contributor

@mdlkxzmcp mdlkxzmcp commented Oct 2, 2023

I wanted to use this lib, but there was no way to pass the password config to Redix, nor other potentially desired options for that matter... So here is a PR for that :)

Added

  • support for all configuration options of Redix (except for name)
  • support for name_prefix config

Breaking

  • port and pool_size config options have to be integers now

Don't mind all the force-pushes... :D

@mdlkxzmcp mdlkxzmcp force-pushed the feat/extend-config branch 3 times, most recently from 40f2aa2 to a9956c1 Compare October 2, 2023 15:25
Copy link
Owner

@alexfilatov alexfilatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! happy to merge!

lib/redix.ex Outdated Show resolved Hide resolved
@mdlkxzmcp mdlkxzmcp force-pushed the feat/extend-config branch 2 times, most recently from 6b2e116 to 8afb7ad Compare February 23, 2024 13:08
@alexfilatov alexfilatov merged commit 267a127 into alexfilatov:master Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants