Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add compliance_v06 workflow to run v06 spec test. #798

Merged
merged 4 commits into from
Sep 17, 2024
Merged

fix: add compliance_v06 workflow to run v06 spec test. #798

merged 4 commits into from
Sep 17, 2024

Conversation

andysim3d
Copy link
Collaborator

[Closes/Fixes] #

Proposed Changes

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.52%. Comparing base (e951cf6) to head (19a18ea).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
unit-tests 57.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 60.59% <ø> (ø)
dev 0.00% <ø> (ø)
pool 64.46% <ø> (ø)
provider 16.10% <ø> (ø)
rpc 25.45% <ø> (ø)
sim 78.53% <ø> (ø)
tasks ∅ <ø> (∅)
types 66.68% <ø> (ø)
utils 18.28% <ø> (ø)

@andysim3d andysim3d force-pushed the andy/spec-06 branch 2 times, most recently from 4c9efb8 to 6b3585b Compare September 17, 2024 18:30
dancoombs
dancoombs approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

0xfourzerofour
0xfourzerofour approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andysim3d andysim3d merged commit 5a07dab into main Sep 17, 2024
6 of 7 checks passed
@andysim3d andysim3d deleted the andy/spec-06 branch September 17, 2024 19:28
dancoombs pushed a commit that referenced this pull request Sep 17, 2024
@andysim3d @dancoombs
fix: add compliance_v06 workflow to run v06 spec test. (#798)
a393636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancoombs dancoombs dancoombs approved these changes

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andysim3d @dancoombs @0xfourzerofour