Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sim): allow mempool configs to modify simulation results #557

Merged
merged 1 commit into from
Jan 19, 2024
Merged

feat(sim): allow mempool configs to modify simulation results #557

merged 1 commit into from
Jan 19, 2024

Conversation

alex-miao
Copy link
Collaborator

@alex-miao alex-miao commented Jan 16, 2024 •
edited
Loading

Fixes #354

Proposed Changes

  • Mark allowlisted unstaked entities as staked

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited
Loading

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (5b5890d) 54.02% compared to head (2001a4e) 54.05%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

Files Coverage Δ
crates/builder/src/bundle_proposer.rs 86.03% <100.00%> (ø)
crates/pool/src/mempool/uo_pool.rs 86.73% <100.00%> (ø)
crates/sim/src/simulation/mempool.rs 96.15% <0.00%> (ø)
crates/sim/src/simulation/simulation.rs 76.19% <71.79%> (-0.25%) ⬇️
Flag Coverage Δ
unit-tests 54.05% <84.61%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 50.09% <100.00%> (ø)
dev 0.00% <ø> (ø)
pool 59.28% <100.00%> (ø)
provider 0.96% <ø> (ø)
rpc 17.16% <ø> (ø)
sim 83.19% <70.00%> (-0.12%) ⬇️
tasks ∅ <ø> (∅)
types 91.51% <ø> (ø)
utils 10.33% <ø> (ø)

@alex-miao alex-miao force-pushed the alex/allow-unstaked branch 2 times, most recently from 260e6d2 to e28a1c8 Compare January 19, 2024 18:17
dancoombs
dancoombs approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good work on the updates, a lot cleaner!

🚢

0xfourzerofour
0xfourzerofour approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@0xfourzerofour 0xfourzerofour left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, looks good to me

@alex-miao alex-miao merged commit 4f2ffe8 into main Jan 19, 2024
6 checks passed
@alex-miao alex-miao deleted the alex/allow-unstaked branch January 19, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dancoombs dancoombs dancoombs approved these changes

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pool: Still track reputation of non-stake-allowed entities.
3 participants
@alex-miao @dancoombs @0xfourzerofour