-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): add state overrides to estimate gas, fix error msg #551
Conversation
Codecov ReportAttention:
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Tested revert bytes by calling https://github.com/eth-infinitism/account-abstraction/blob/187613b0172c3a21cf3496e12cdfa24af04fb510/contracts/core/EntryPoint.sol#L356 on the entry point, the revert error is correctly formatted.
|
10c3290
to
a5938e5
Compare
0596164
to
ab4d267
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a nit math comment
3d50c55
to
73bd520
Compare
73bd520
to
b6629b5
Compare
b6629b5
to
d8874fc
Compare
Closes #525
Closes #530
Proposed Changes
eth_estimateUserOperationGas
revert_bytes
in the data field of theeth_estimateUserOperationGas
error responseTODO