-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(git): improve parsing of worktree list #2548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hiddeco
force-pushed
the
fix-worktree-list
branch
2 times, most recently
from
September 19, 2024 21:50
446b758
to
fafea65
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2548 +/- ##
==========================================
+ Coverage 50.54% 50.61% +0.06%
==========================================
Files 278 278
Lines 20438 20471 +33
==========================================
+ Hits 10331 10362 +31
- Misses 9472 9473 +1
- Partials 635 636 +1 ☔ View full report in Codecov by Sentry. |
hiddeco
force-pushed
the
fix-worktree-list
branch
from
September 19, 2024 21:58
fafea65
to
733369d
Compare
hiddeco
force-pushed
the
fix-worktree-list
branch
from
September 19, 2024 22:11
733369d
to
01217cd
Compare
hiddeco
force-pushed
the
fix-worktree-list
branch
from
September 19, 2024 22:29
01217cd
to
3af8ec6
Compare
Signed-off-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
fix-worktree-list
branch
from
September 19, 2024 22:30
3af8ec6
to
334547a
Compare
krancour
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the listing of Git worktrees by implementing a more robust parsing mechanism for the
git worktree list
command output. The previous implementation struggled with certain edge cases, such as detached HEAD states, leading to parsing errors:The new approach utilizes the
--porcelain
option and introduces a line-by-line parsing strategy, capable of extracting detailed information about each worktree, including its path, HEAD commit, branch, etc. without relying on a specific number of columns.