Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport release-0.8): fix(controller): improve logic to determine when syncing an argo cd app is required #2442

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

akuitybot
Copy link

Automated backport to release-0.8, triggered by a label in #2433.

…pp is required (#2433)

Signed-off-by: Kent Rancourt <[email protected]>
(cherry picked from commit af685c3)
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit d7520e5
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66bfae051e872c00087aaf7e
😎 Deploy Preview https://deploy-preview-2442.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@krancour krancour enabled auto-merge (squash) August 16, 2024 19:54
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 68.25397% with 40 lines in your changes missing coverage. Please review.

Project coverage is 46.76%. Comparing base (1e0919b) to head (d7520e5).
Report is 1 commits behind head on release-0.8.

Files Patch % Lines
internal/controller/promotion/pullrequest.go 0.00% 17 Missing ⚠️
internal/controller/promotions/promotions.go 0.00% 12 Missing ⚠️
internal/controller/promotion/composite.go 84.84% 3 Missing and 2 partials ⚠️
internal/controller/promotion/git.go 79.16% 5 Missing ⚠️
internal/controller/promotion/argocd.go 97.50% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.8    #2442      +/-   ##
===============================================
+ Coverage        46.65%   46.76%   +0.10%     
===============================================
  Files              246      246              
  Lines            17703    17699       -4     
===============================================
+ Hits              8260     8277      +17     
+ Misses            9017     8994      -23     
- Partials           426      428       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour merged commit c6bcd85 into release-0.8 Aug 16, 2024
23 checks passed
@krancour krancour deleted the backport-2433-to-release-0.8 branch August 16, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants