Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): hide subscriptions button should be per warehouse #2211

Closed
wants to merge 2 commits into from

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Jun 27, 2024

Fixes #2125

@rbreeze rbreeze requested a review from a team as a code owner June 27, 2024 16:04
Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 48b71c4
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/667f2c7f28926a0008354939
😎 Deploy Preview https://deploy-preview-2211.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.30%. Comparing base (93940f9) to head (48b71c4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2211   +/-   ##
=======================================
  Coverage   46.30%   46.30%           
=======================================
  Files         242      242           
  Lines       16767    16767           
=======================================
  Hits         7764     7764           
  Misses       8632     8632           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbreeze rbreeze self-assigned this Jun 27, 2024
@krancour krancour changed the title fix(ui): hide subscriptions button should be per warehouse refactor(ui): hide subscriptions button should be per warehouse Jun 27, 2024
@krancour krancour added this to the v0.8.0 milestone Jun 27, 2024
@krancour krancour modified the milestones: v0.8.0, v0.9.0 Jul 16, 2024
@krancour
Copy link
Member

Setting this to draft because I know there are outstanding issues with this that @rbreeze and I have discussed offline.

@krancour krancour marked this pull request as draft July 22, 2024 19:34
@rbreeze
Copy link
Contributor Author

rbreeze commented Aug 6, 2024

Closing in favor of #2396 - was easier to start over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: make show/hide warehouse subs button show/hide only subs for one warehouse
2 participants