chore(api): remove redundant setter from Promotion (#1897)

Signed-off-by: Hidde Beydals <[email protected]>
akuity · Apr 27, 2024 · 14522e0 · 14522e0
1 parent eb75e27
commit 14522e0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/api/v1alpha1/promotion_types.go b/api/v1alpha1/promotion_types.go
@@ -112,13 +112,6 @@ func (p *PromotionStatus) WithPhase(phase PromotionPhase) *PromotionStatus {
 	return status
 }
 
-// WithFreight returns a copy of PromotionStatus with the given freight
-func (p *PromotionStatus) WithFreight(freight *FreightReference) *PromotionStatus {
-	status := p.DeepCopy()
-	status.Freight = freight
-	return status
-}
-
 // +kubebuilder:object:root=true
 
 // PromotionList contains a list of Promotion

diff --git a/internal/controller/promotions/promotions.go b/internal/controller/promotions/promotions.go
@@ -457,7 +457,7 @@ func (r *reconciler) promote(
 	if err != nil {
 		return nil, err
 	}
-	newStatus = newStatus.WithFreight(&nextFreight)
+	newStatus.Freight = &nextFreight
 
 	logger.Debugf("promotion %s", newStatus.Phase)