[11.0][MIG] account_invoice_update_wizard #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
suggested changes
Oct 19, 2018
| Account Invoice Update Wizard | ||
| ============================= | ||
|
|
||
| This module adds a button *Update Invoice* on Customer and Supplier invoices in Open or Paid state. This button starts a wizard which allows the user to update non-legal fields of the invoice: |
There was a problem hiding this comment.
move 'This button starts...' to a new line
|
|
||
| * Source Document | ||
| * Reference/Description | ||
| * Payment terms (update allowed only to a payment term with same number of terms of the same amount and on invoices without any payment) |
There was a problem hiding this comment.
same: make this more readable... new lines are cheap ;)
|
|
||
| class TestAccountInvoiceUpdateWizard(TransactionCase): | ||
|
|
||
| def setUp(self): |
There was a problem hiding this comment.
use SavepointCase + setUpClass + cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
|
|
||
| """, | ||
| 'author': 'Akretion', | ||
| 'website': 'http://www.akretion.com', |
There was a problem hiding this comment.
if this is published on odoo apps it would be better to have https://github.com/akretion/odoo-usability
| @@ -0,0 +1,29 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <!-- | |||
| © 2017 Akretion (Alexis de Lattre <[email protected]>) | |||
tschanzt
approved these changes
Oct 31, 2018
Tonow-c2c
reviewed
Nov 12, 2018
There was a problem hiding this comment.
Please doing readme like this https://github.com/OCA/maintainer-tools/tree/master/template/module/readme
and improving fields declaration indentation like :
fields_id = fields.Many2one(
'module.[...]',
string='My name',
required=True,
readonly=True
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.