purchase_stock_usability: Reception status on PO and PO lines #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
replace #149 |
|
@alexis-via I've just found your module purchase_reception_status in OCA purchase-workflow ! https://github.com/OCA/purchase-workflow/tree/14.0/purchase_reception_status You should have told me when I submitted #149 ! ;) So in your module the status is based on quantities received whereas here I just copied the sale_stock_usability and used the stock.picking's status to compute it... I don't know if I have a preference. What's your opinion about it ? Should I make a PR on your OCA module to submit this status computation at PO line level ? Thanks ! |
clementmbr
force-pushed
the
14.0-picking-status-po-line
branch
from
a8c93f3
to
f4f0eb1
Compare
clementmbr
changed the title
clementmbr
force-pushed
the
14.0-picking-status-po-line
branch
from
f4f0eb1
to
b0dbd81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients may want to follow the Reception status at PO line level in addition to PO level. So I moved the status computation to the purchase.order.line model.
It does not change the previous behavior, just add the possibility to display this Reception Status on PO line tree or PO tree.
cc @rvalyi @alexis-via