-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] mail_single_send_several_recipients module #128
Open
chafique-delli
wants to merge
3
commits into
10.0
Choose a base branch
from
10.0-ADD-mail_single_send_several_recipients
base: 10.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
Mail Single Send with Several Recipients | ||
======================================== | ||
|
||
With this module, when there are several recipients, | ||
Odoo sends only one single e-mail with all the addressees instead of one email per address. | ||
|
||
Credits | ||
======= | ||
|
||
Contributors | ||
------------ | ||
|
||
* Chafique Delli ([email protected]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# -*- coding: utf-8 -*- | ||
|
||
from . import models |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
# -*- coding: utf-8 -*- | ||
{ | ||
'name': 'Mail Single Send with Several Recipients', | ||
'version': '10.0.1.0.0', | ||
'category': 'Mail', | ||
'license': 'AGPL-3', | ||
'summary': "When there are several recipients, always send only one e-mail for all the addressees", | ||
'author': 'Akretion', | ||
'website': 'http://www.akretion.com', | ||
'depends': ['mail'], | ||
'installable': True, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# -*- coding: utf-8 -*- | ||
|
||
from . import mail_mail |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
# -*- coding: utf-8 -*- | ||
|
||
from odoo import models, api | ||
from email.utils import formataddr | ||
|
||
|
||
class MailMail(models.Model): | ||
_inherit = 'mail.mail' | ||
|
||
@api.multi | ||
def send(self, auto_commit=False, raise_exception=False): | ||
for mail in self: | ||
email_to = [] | ||
for partner in mail.recipient_ids: | ||
for partner_email in [formataddr((partner.name, partner.email))]: | ||
email_to.append(partner_email) | ||
mail.email_to = email_to | ||
return super(MailMail, self).send(auto_commit=auto_commit, | ||
raise_exception=raise_exception) | ||
|
||
@api.multi | ||
def send_get_mail_to(self, partner=None): | ||
super(MailMail, self).send_get_mail_to(partner=partner) | ||
self.ensure_one() | ||
email_to = [] | ||
for partner in self.recipient_ids: | ||
email_to.append(formataddr((partner.name, partner.email))) | ||
self.recipient_ids = [(6, 0, [])] | ||
return email_to |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no super ?
Why not the following :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hparfr ,
Because the super() method without partner uses the 'tools.email_split_and_format' method which uses the 'email.utils.getaddresses' method which does not list email addresses correctly.