This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
delete runtime to allow build in both netlify and cloudflare pages #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for developer-aiven-io-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed, and why it matters
Currently docs.aiven.io is hosted in Netlify which support the latest Python version 3.8. As we are migrating the deployment platform to Cloudflare Pages, currently the build support version up to Python 3.7 only.
Prior to the switch of deployment platform, build need to support both Netlify and Cloudflare Pages. To avoid conflict of version, we can remove this runtime.txt and set the Python version as environment variable in both Netlify and Cloudflare Pages. Documentation here.
Related to Issue 1528
Preview
Build successfully in both Netlify and Cloudflare Pages.
Netlify https://deploy-preview-1645--developer-aiven-io-preview.netlify.app/
Cloudflare Pages https://delete-runtime-allow-build-n.devportal.pages.dev/