Prevent JVM crash when buffer too small #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/prevent-jvm-crash-when-buffer-too-small-82cd0a
branch
2 times, most recently
from
8d6596b
to
a03c8a7
Compare
The test was passing incorrect value for `maxOutputLength`.
findepi
force-pushed
the
findepi/prevent-jvm-crash-when-buffer-too-small-82cd0a
branch
from
a03c8a7
to
89892d7
Compare
martint
reviewed
Apr 12, 2022
| // mis-declared buffer size | ||
| byte[] compressedChoppedOff = Arrays.copyOf(compressed, compressedLength - 1); | ||
| throwable = catchThrowable(() -> decompressor.decompress(compressedChoppedOff, 0, compressedLength, data, 0, data.length)); | ||
| if (throwable instanceof UncheckedIOException) { |
There was a problem hiding this comment.
Who throws this exception? In general, there shouldn’t be any IO related exceptions involved.
There was a problem hiding this comment.
GZIP code under the hood, AFAIR
(the expected exceptions are "whatever is looks somewhat reasonable", the fact that there is an exception is the most important part)
martint
approved these changes
Apr 12, 2022
findepi
deleted the
findepi/prevent-jvm-crash-when-buffer-too-small-82cd0a
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #142