Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use ecmaVersion latest #2965

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Apr 10, 2024

The following code is often used when using @eslint/eslintrc with eslint-config-airbnb-base:

// mimic CommonJS variables -- not needed if using CommonJS
const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: pluginJs.configs.recommended});

However, import.meta is not supported in ecmaVersion: '2018'. This change allows users to be able to use it that way.

The following code is often used when using @eslint/eslintrc with `eslint-config-airbnb-base`:

```js
// mimic CommonJS variables -- not needed if using CommonJS
const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: pluginJs.configs.recommended});
```

However, `import.meta` is not supported in ecmaVersion: '2018'. This change allows users to be able to use it that way.
@aladdin-add
Copy link
Contributor Author

related: eslint/create-config#51

@@ -10,7 +10,7 @@ module.exports = {
'./rules/strict',
].map(require.resolve),
parserOptions: {
ecmaVersion: 2018,
ecmaVersion: 'latest',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a change we can't make unless babel-preset-airbnb is handling it by default. unfortunately i no longer maintain it, so I'm not familiar with what the latest version supports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems it's no longer actively maintained - the last version was released ~4 years ago.
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accurate. but this is airbnb's eslint config, so my hands are kind of tied :-/

@ljharb ljharb marked this pull request as draft August 23, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants