Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aiidalab-widgets-base from app store #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Feb 21, 2024

@danielhollas
Copy link

I think we should wait with this until AWB is in the base image, to be on the safe side. Also I believe there is some functionality in that @yakutovicha wants to migrate to aiidalab-home?

@unkcpz
Copy link
Member Author

unkcpz commented Feb 21, 2024

I think we should wait with this until AWB is in the base image, to be on the safe side.

Why? I didn't see the potential problem. If the app need AWB then it is in the dependencies of the app.

@danielhollas
Copy link

danielhollas commented Feb 21, 2024 via email

@unkcpz
Copy link
Member Author

unkcpz commented Feb 21, 2024

Emm... this is a good point. But how to test it?

@danielhollas
Copy link

danielhollas commented Feb 21, 2024 via email

@yakutovicha
Copy link
Member

I think we should wait with this until AWB is in the base image, to be on the safe side. Also I believe there is some functionality in that @yakutovicha wants to migrate to aiidalab-home?

Yes, indeed, I need to migrate those notebooks to the aiidalab-home app first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants