Merge pull request #93 from eprogramming/master

fix pmd default rules
aeshell · Feb 10, 2015 · 5b7711c · 5b7711c
2 parents ba50a62 + 6a90fdf
commit 5b7711c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/build.gradle b/build.gradle
@@ -23,9 +23,10 @@ apply plugin: 'idea'
 apply plugin: 'eclipse'
 apply plugin: 'maven'
 apply plugin: 'application'
+apply plugin: 'pmd'
 
 group = 'org.jboss.aesh'
-version = '0.57-SNAPSHOT'
+version = '0.57'
 
 mainClassName = 'org.jboss.aesh.mterm.Mterm'
 
@@ -49,12 +50,12 @@ test {
 
 dependencies {
     compile group: 'org.jboss.aesh', name: 'aesh', version: version
-    compile group: 'org.jboss.aesh', name: 'aesh-extensions', version: version
+    compile group: 'org.jboss.aesh', name: 'aesh-extensions', version: '0.57-SNAPSHOT'
     compile group: 'org.codehaus.groovy', name: 'groovy', version: '2.1.6'
     testCompile group: 'junit', name: 'junit', version: '4.+'
     testCompile group: 'org.easytesting', name: 'fest-swing', version: '1.2.1'
 }
 
 task wrapper(type: Wrapper) {
     gradleVersion = '2.2.1'
-}
+}
diff --git a/src/main/java/org/jboss/aesh/mterm/action/BaseAction.java b/src/main/java/org/jboss/aesh/mterm/action/BaseAction.java
@@ -45,7 +45,7 @@ protected String readLine() {
             int lineOffset = textArea.getLineOfOffset(textArea.getCaretPosition());
             int lineStart = textArea.getLineStartOffset(lineOffset);
             int lineEnd = textArea.getLineEndOffset(lineOffset);
-            return textArea.getText(lineStart, (lineEnd - lineStart));
+            return textArea.getText(lineStart, lineEnd - lineStart);
         }
         catch (BadLocationException e) {
             e.printStackTrace();

diff --git a/src/main/java/org/jboss/aesh/mterm/action/menu/MenuTitleAction.java b/src/main/java/org/jboss/aesh/mterm/action/menu/MenuTitleAction.java
@@ -36,8 +36,5 @@ public void actionPerformed(ActionEvent e) {
                 JOptionPane.PLAIN_MESSAGE, null, null, mtermUI.getTitle());
 
         mtermUI.setTitle(newTitle);
-
-        return;
-
     }
 }
diff --git a/src/main/java/org/jboss/aesh/mterm/util/AeshUtil.java b/src/main/java/org/jboss/aesh/mterm/util/AeshUtil.java
@@ -105,7 +105,7 @@ public String getResult() {
      * @throws IOException exception
      */
     public void run(String command) throws IOException {
-        getPos().write((command).getBytes());
+        getPos().write(command.getBytes());
         getPos().write(Config.getLineSeparator().getBytes());
         getPos().flush();
         pause();