FMWK-569 Add support for the partition-list option #153
+551
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
filkeith
commented
Sep 24, 2024
filkeith
commented
- added support of partition list parameter
- refactored after-digest parameter
- refactored partition range
- added prefer racks - fixed error with nodes and partitions backup
- added support of partition list parameter - refactored after-digest parameter - refactored partition range
- review fixes
filkeith
changed the title
# Conflicts: # cmd/asbackup/readme.md # cmd/internal/app/configs.go # cmd/internal/flags/backup.go # cmd/internal/flags/backup_test.go # cmd/internal/models/backup.go
# Conflicts: # cmd/asbackup/readme.md # cmd/internal/app/configs.go # cmd/internal/flags/backup.go # cmd/internal/flags/backup_test.go # cmd/internal/models/backup.go
- fixed splitting partitions
- tests
- added test - fixed config test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 80.86% 80.53% -0.34%
==========================================
Files 85 85
Lines 4735 4844 +109
==========================================
+ Hits 3829 3901 +72
- Misses 636 662 +26
- Partials 270 281 +11 ☔ View full report in Codecov by Sentry. |
- removed debug output
- renamed method
reugn
reviewed
Sep 25, 2024
- review fixes - count records for nodes and partitions fix
reugn
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.