FMWK-563 Make check for emptiness only for directory #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
filkeith
commented
Sep 22, 2024
filkeith
commented
- we check only dir if it is empty
- we check only dir if it is empty
- removed test for one file for empty folder, as we don't check it
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 81.12% 81.17% +0.05%
==========================================
Files 85 85
Lines 4614 4617 +3
==========================================
+ Hits 3743 3748 +5
+ Misses 613 609 -4
- Partials 258 260 +2 ☔ View full report in Codecov by Sentry. |
| @@ -223,15 +223,6 @@ func (s *writeReadTestSuite) writeSingleFile(filename string, bytes, times int, | |||
| s.FailNow("failed to close writer", err) | |||
| } | |||
|
|
|||
| // cannot create new streamingReader because folder is not empty | |||
There was a problem hiding this comment.
well, it's a good test, we can leave it.
just use WithDir
btw, there is misprint in s3Storasge
There was a problem hiding this comment.
or, change assertion to "require no error"
There was a problem hiding this comment.
it is writeSingleFile test, so can't use WithDir here. Also with no error is is tested above
korotkov-aerospike
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.