remove ASBEncoder writer field

backup_handlers.go

@@ -171,7 +171,6 @@ func (bwh *BackupToWriterHandler) Wait() error {
 }
 
 func getDataWriter(eb EncoderBuilder, w io.Writer, namespace string, first bool) (datahandlers.Writer, error) {
-	eb.SetDestination(w)
 	enc, err := eb.CreateEncoder()
 	if err != nil {
 		return nil, err

config.go

@@ -73,7 +73,6 @@ type Encoder interface {
 
 type EncoderBuilder interface {
 	CreateEncoder() (Encoder, error)
-	SetDestination(dest io.Writer)
 }
 
 // BackupBaseConfig contains shared configuration for backup operations

encoder/asb.go

@@ -18,7 +18,6 @@ import (
 	"encoding/base64"
 	"errors"
 	"fmt"
-	"io"
 	"math"
 	"time"
 
@@ -31,14 +30,10 @@ const (
 	ASBFormatVersion = "3.1"
 )
 
-type ASBEncoder struct {
-	writer io.Writer
-}
+type ASBEncoder struct{}
 
-func NewASBEncoder(w io.Writer) (*ASBEncoder, error) {
-	return &ASBEncoder{
-		writer: w,
-	}, nil
+func NewASBEncoder() (*ASBEncoder, error) {
+	return &ASBEncoder{}, nil
 }
 
 func (o *ASBEncoder) EncodeRecord(rec *models.Record) ([]byte, error) {

encoder/asb_test.go

@@ -34,8 +34,7 @@ type asbEncoderTestSuite struct {
 }
 
 func (suite *asbEncoderTestSuite) TestEncodeRecord() {
-	dst := &strings.Builder{}
-	encoder, err := NewASBEncoder(dst)
+	encoder, err := NewASBEncoder()
 	if err != nil {
 		suite.FailNow("unexpected error: %v", err)
 	}
@@ -70,8 +69,7 @@ func (suite *asbEncoderTestSuite) TestEncodeRecord() {
 }
 
 func (suite *asbEncoderTestSuite) TestEncodeSIndex() {
-	dst := &strings.Builder{}
-	encoder, err := NewASBEncoder(dst)
+	encoder, err := NewASBEncoder()
 	if err != nil {
 		suite.FailNow("unexpected error: %v", err)
 	}

encoders.go

@@ -31,17 +31,8 @@ func NewASBEncoderBuilder() *ASBEncoderBuilder {
 	return &ASBEncoderBuilder{}
 }
 
-// SetDestination sets the destination for the ASBEncoder
-// This is method is called by the backup client to set the destination
-// Users of the backup client should not call this method
-func (f *ASBEncoderBuilder) SetDestination(dst io.Writer) {
-	f.dst = dst
-}
-
 // CreateEncoder creates a new ASBEncoder
 // This method is called by the backup client to create a new encoder
 func (f *ASBEncoderBuilder) CreateEncoder() (Encoder, error) {
-	return encoder.NewASBEncoder(
-		f.dst,
-	)
+	return encoder.NewASBEncoder()
 }