Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly parse sessionId for chrome less 75 #1361

Merged

Conversation

DudaGod
Copy link
Contributor

@DudaGod DudaGod commented Jul 13, 2023

In the process of implementing #1354, I broke work with the chrome browser version below 75. Response body from chrome@67 looks like this:

{
    sessionId: "session_id",
    status: 0,
    value: {
        browserName: "chrome",
        // ... (without "capabilities" field)
    }
}

In chrome 75 and older looks like this:

{
    value: {
        capabilities: {
            browserName: "chrome",
            // ...
        },
        sessionId: "session_id"
    }
}

It means that sessionId can be located in different places depending on browser version.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 61.90% and project coverage change: -0.27 ⚠️

Comparison is base (33d6893) 74.44% compared to head (e18077a) 74.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1361      +/-   ##
==========================================
- Coverage   74.44%   74.17%   -0.27%     
==========================================
  Files          12       12              
  Lines        1831     1847      +16     
==========================================
+ Hits         1363     1370       +7     
- Misses        383      391       +8     
- Partials       85       86       +1     
Flag Coverage Δ
go 74.17% <61.90%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
selenoid.go 83.12% <61.90%> (-1.34%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

selenoid.go Outdated Show resolved Hide resolved
@DudaGod DudaGod force-pushed the fix.parse_session_id_chrome_less_75 branch from 8615bbf to e18077a Compare July 13, 2023 15:19
@vania-pooh vania-pooh merged commit e83931c into aerokube:master Jul 14, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants