Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mp4 video provider and add Brighton Ruby 2023 videos #167

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marcoroth
Copy link
Contributor

This pull request implements a new video_provider for the case where the videos are not hosted on YouTube. In the case of Brighton Ruby they are hosted on their own website.

So this pull request implements a new mp4 video provider, where the video_id is the link to the MP4 file.

CleanShot 2024-08-26 at 22 05 36

@adrienpoly
Copy link
Owner

Thanks for this great addition.

I think we should ask @andycroll permission first. Organizers who are publishing their videos on Youbute defacto accept that their video can be embedded into another website as it is a native feature of Youtube. Also videos viewed from embedded players do count for the view stats on Youtube.

For orgs having made the choice to host by themself the videos, I think we should get their explicit consent first.

One option could be that we just pull the metadata + Thumbnail and link to the Org website for the player (to be decided by the org)

@marcoroth
Copy link
Contributor Author

Good point, I'm more than happy to extract the video provider to its own pull request, since it's technically two "features" in one pull request.

I was just testing the mp4 "provider" with the lastest Brighton Ruby edition, since I knew they were using their own video hosting.

@adrienpoly
Copy link
Owner

Good point, I'm more than happy to extract the video provider to its own pull request, since it's technically two "features" in one pull request.

I was just testing the mp4 "provider" with the lastest Brighton Ruby edition, since I knew they were using their own video hosting.

I will send an email to Andy. Don’t change anything for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants