Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon native classes #814

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

maxwondercorn
Copy link
Collaborator

Decorators (tagName, classNamesBindings, etc) remain because outer HTML breaks demo app/tests due to the extra divs. Using @tagName('') to remove them causes other errors.

I believe everything needs to be converted to glimmer to finish the cleanup.

addObserver, removeObserver are used instead of the @observes decorator because it's not glimmer compatible

@vstefanovic97
Copy link
Contributor

@maxwondercorn , @rwwagner90. Do you have a plan or currently work in progress to convert this to glimmer?
I would like to help in the effort to update this addon.
Not sure if you want to convert everything in one go or do you think it is a better idea to just create incremental PRs upgrading parts until we have covered everything?

@RobbieTheWagner
Copy link
Member

@vstefanovic97 we would love the help! I think either way is fine.

Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to take another look at what should be @tracked and make sure all the things are updating as we expect. Alternatively, we could put back some of the old computeds.

addon/components/cells/base.js Outdated Show resolved Hide resolved
addon/components/cells/base.js Show resolved Hide resolved
addon/components/columns/base.js Show resolved Hide resolved
addon/components/draggable-column.js Outdated Show resolved Hide resolved
addon/components/draggable-column.js Outdated Show resolved Hide resolved
addon/components/draggable-column.js Outdated Show resolved Hide resolved
addon/components/draggable-column.js Outdated Show resolved Hide resolved
addon/components/draggable-column.js Outdated Show resolved Hide resolved
addon/components/lt-column-resizer.js Outdated Show resolved Hide resolved
addon/components/lt-column-resizer.js Outdated Show resolved Hide resolved
@maxwondercorn
Copy link
Collaborator Author

I think we need to take another look at what should be @tracked and make sure all the things are updating as we expect. Alternatively, we could put back some of the old computeds.

Added computed back. Most properties are on the class which still need to be converted to native classes

@RobbieTheWagner
Copy link
Member

@maxwondercorn I totally forgot about this PR, sorry about that! Where did we leave off?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants