Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run 24h check for json #84

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

RemoLiechti
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@RemoLiechti RemoLiechti merged commit 0b3231a into main Jun 3, 2024
3 checks passed
@RemoLiechti RemoLiechti deleted the rliechti_json_24hcheck branch June 3, 2024 12:24
Comment on lines +50 to +54
if (
!flags.quiet &&
!flags.json &&
this.constructor.name !== 'SetupCommand'
) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this read more easily?

Suggested change
if (
!flags.quiet &&
!flags.json &&
this.constructor.name !== 'SetupCommand'
) {
if (!(flags.quiet || flags.json || this.constructor.name === 'SetupCommand')) {

On a more general note, I dislike the mentioning of individual implementations (i.e. SetupCommand) in base classes. Better would be a method, e.g. isInteractive() (or whatever really makes sense) that can be overridden in individual commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants