Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed XML in React/latest ui.content #26

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

actinium15
Copy link

Fixes #25

Removes the linefeed that breaks XML compilance

Motivation and Context

It isn't possible to install the ui.content artifact built from React/latest branch on AEM.
Since this is an ~year old change (from Aug '20), it is likely to exist in other branches as well, but I haven't gone down that path.

How Has This Been Tested?

  • built the ui.content and the dependencies from the latest state of the branch; installation of artifact failed on AEM
  • applied the patch, rebuilt the content-package; installation of artifact on AEM succeeded.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • All new and existing tests passed.

@actinium15
Copy link
Author

@godanny86, for your consideration (can't add you as a reviewer)

@davidjgonzalez davidjgonzalez merged commit 8a792c5 into adobe:React/latest Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants