Make handlers Deferrable-aware #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this has a merge conflict now. Would you take a look and resolve as necessary? I'll be honest that I haven't reviewed this too closely, but it looks backward compatible and makes sense given your other work in this space. 👍 |
If a handler returns an EM::Deferrable, wait for the EM result to be ready before considering the handler complete, raising an error result as an exception in the current context just like a non-async handler would have done. This allows async filters/handlers to run in order. To be able to sync, handle_data is wrapped in a Fiber. To aid in testing or other cases that want to wait until the whole process is done, handle_data returns an EM::Deferrable that will signal the success or failure of the whole process (for both the sync and async cases). This can be safely ignored by most callers.
singpolyma
force-pushed
the
defer-aware
branch
from
e51f153
to
f78d56e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a handler returns an EM::Deferrable, wait for the EM result to be ready
before considering the handler complete, raising and error result as an
exception in the current context just like a non-async handler would have done.
This allows async filters/handlers to run in order.
To be able to sync, handle_data is wrapped in a Fiber. To aid in testing or
other cases that want to wait until the whole process is done, handle_data
returns an EM::Deferrable that will signal the success or failure of the whole
process (for both the sync and async cases). This can be safely ignored by most
callers.