Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DS2484 hosting DS18b20 temp sensor #603

Merged
merged 9 commits into from
Jul 23, 2024
Merged

Add DS2484 hosting DS18b20 temp sensor #603

merged 9 commits into from
Jul 23, 2024

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Jul 18, 2024

Adds DS18b20 hosted on DS2484, with tolerance for disconnects of DS18b20

image

@tyeth
Copy link
Contributor Author

tyeth commented Jul 18, 2024

and a disconnected device from the start:
image

@tyeth tyeth requested a review from brentru July 22, 2024 15:49
@tyeth
Copy link
Contributor Author

tyeth commented Jul 22, 2024

@brentru this is ready for review

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyeth Looks good overall! Requesting some clarification/changes.

@tyeth
Copy link
Contributor Author

tyeth commented Jul 23, 2024

@brentru should be good to go

@tyeth tyeth requested a review from brentru July 23, 2024 19:43
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brentru brentru merged commit 042597a into main Jul 23, 2024
31 checks passed
@brentru brentru deleted the add-DS2484 branch July 23, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants