Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rtc function #76

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rtc function #76

wants to merge 2 commits into from

Conversation

dave-mc
Copy link

@dave-mc dave-mc commented Nov 6, 2016

The Fona::readRTC function was incomplete in the library so I have contributed my updated function to return the RTC values obtained from the GSM signal.
As the GSM clock is based on local time I have extended the definition to include the time zone as well (in GSM format +/- x 15min intervals from GMT)

Tested with FONA808

dave-mc added 2 commits November 6, 2016 17:53
Extended function to add Time Zone and added body to function to return
all RTC fields.
Changed reply variable to reply and removed repeated declarations
@fred-maria
Copy link

Hello, dave-mc.
It is a pity that your contribution has not been pulled. Indeed, I just did quite the same changes to the code so I get a working readRTC().
Also, it seems the continuous integration is somewhat broken as the SoftwareSerial.h file is not found !

Copy link

@simonmags simonmags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, would be good to have this commit pulled into the main branch to fix some of the time issues.

@OscarVanL
Copy link

OscarVanL commented Apr 4, 2020

I can confirm this works for the FONA 3G too. Such a shame this hasn't been merged despite how long this has been a PR for. This repo really needs some love.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants