This repository has been archived by the owner on Dec 25, 2022. It is now read-only.
[WIP] Migrate to newest Actix #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATTENTION maintainers: several of the examples need your expert opinion - they are currently panicking with ``` thread 'main' panicked at '`spawn_local` called from outside of a `task::LocalSet`', .cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.19.2/src/task/local.rs:306:18 ``` * Update to latest Actix * Fix build instructions * Mark several tests as failing to avoid confusing users
|
@robjtede thx for merging the other PRs, I tried to migrate to the new version of Actix, but i think I might need an expert to look over the changes - I wouldn't want to give the wrong info in the book, but the current info is severely outdated. Any feedback would be great, thx! |
As far as I can tell, since actix-rt v2, you have to run actors inside |
JohnTitor
reviewed
Jun 19, 2022
Comment on lines
+19
to
+20
| # intellij files | ||
| **/.idea |
There was a problem hiding this comment.
I'd prefer to place it on your gitignore config.
|
Could you also upgrade MSRV CI to 1.54? Or, we even don't have to check MSRV here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATTENTION maintainers: several of the examples need your expert opinion - they are currently panicking with