Update Rubocop, enable new cops, fix offenses #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #902 +/- ##
==========================================
+ Coverage 98.73% 98.91% +0.18%
==========================================
Files 14 14
Lines 555 555
==========================================
+ Hits 548 549 +1
+ Misses 7 6 -1 ☔ View full report in Codecov by Sentry. |
javierjulio
reviewed
Mar 4, 2024
| end | ||
|
|
||
| # Get collection ivar based on the current resource controller. | ||
| # | ||
| def get_collection_ivar #:nodoc: | ||
| if instance_variable_defined?(:"@#{resource_collection_name}") | ||
| instance_variable_get("@#{resource_collection_name}") | ||
| instance_variable_get(:"@#{resource_collection_name}") |
There was a problem hiding this comment.
This is the only line that has no test coverage. Do you think it would be possible to add a single test case for this?
There was a problem hiding this comment.
Done. It is not beautiful, but it does the job
There was a problem hiding this comment.
No worries. What you did was exactly what I was thinking. This is great and just what we needed. Thank you.
tagliala
force-pushed
the
chore/update-rubocop
branch
from
5719a1f
to
f1db729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.