Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove table tag defaults #516

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Remove table tag defaults #516

merged 1 commit into from
Jul 21, 2023

Conversation

javierjulio
Copy link
Member

@javierjulio javierjulio commented Jul 21, 2023

These are unnecessary for a long time now as they can be controlled easily through CSS. It would be best to have no overrides for these elements (other p/para due to the name clash).

This PR and #517 will be in a major (v2) release due to being a breaking change.

These are unnecessary for a long time now as they can be controlled easily through CSS. It would be best to have no overrides for these elements (other p/para due to the name clash).
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.90 🎉

Comparison is base (6887c96) 91.66% compared to head (f88f279) 92.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
+ Coverage   91.66%   92.56%   +0.90%     
==========================================
  Files          17       17              
  Lines         480      471       -9     
==========================================
- Hits          440      436       -4     
+ Misses         40       35       -5     
Impacted Files Coverage Δ
lib/arbre/html/html5_elements.rb 100.00% <ø> (+29.41%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@javierjulio javierjulio merged commit 186106d into master Jul 21, 2023
14 checks passed
@javierjulio javierjulio deleted the remove-table-tag-defaults branch July 21, 2023 21:06
javierjulio added a commit that referenced this pull request Oct 8, 2023
javierjulio added a commit that referenced this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant