Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Add account_cash_discount_base addons #1

Open
wants to merge 32 commits into
base: 8.0
Choose a base branch
from

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Nov 20, 2014

Do not merge this one - it is for internal review only.

.travis.yml Outdated
@@ -12,6 +12,7 @@ virtualenv:

install:
- git clone https://github.com/OCA/maintainer-quality-tools.git ${HOME}/maintainer-quality-tools
- git clone -b 8.0-refactor-account_banking_payment-sbi https://github.com/acsone/banking.git ${HOME}/banking
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary anymore.

@sbidoul
Copy link
Member Author

sbidoul commented Dec 1, 2014

@adrienpeiffer you probably have not seen these comments.

@adrienpeiffer adrienpeiffer force-pushed the 8.0-add-account-cash-discount-base-ape branch from 6a48457 to 3b14869 Compare December 2, 2014 13:51
@adrienpeiffer adrienpeiffer force-pushed the 8.0-add-account-cash-discount-base-ape branch 4 times, most recently from 9e60b47 to 7493eba Compare January 20, 2015 19:30
@adrienpeiffer
Copy link

Rebased

@adrienpeiffer adrienpeiffer force-pushed the 8.0-add-account-cash-discount-base-ape branch 2 times, most recently from a130ee3 to 04155a7 Compare January 20, 2015 21:15
@@ -0,0 +1,2 @@
Account Cash Discount Base
===
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

underlines the entire sentence
A somewhat more complete description would be nice. 😄

@adrienpeiffer adrienpeiffer force-pushed the 8.0-add-account-cash-discount-base-ape branch from 0ac6422 to 8f62449 Compare January 23, 2015 07:24
@adrienpeiffer adrienpeiffer force-pushed the 8.0-add-account-cash-discount-base-ape branch 3 times, most recently from 0984153 to 7d538eb Compare February 11, 2015 21:18
@adrienpeiffer
Copy link

@lmignon Sorry for the delay but I finally found the time to reflect about your comments. Thanks a lots for this review 😄

@adrienpeiffer adrienpeiffer force-pushed the 8.0-add-account-cash-discount-base-ape branch from 0161af4 to 0a42922 Compare March 25, 2015 18:42
@adrienpeiffer adrienpeiffer force-pushed the 8.0-add-account-cash-discount-base-ape branch from 8c29554 to 8d7d4c9 Compare November 22, 2017 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants